Spent the weekend in Philadelphia. On Saturday Victoria and I went to the Mutter Museum of Medical Oddities. Pretty disturbing stuff.
Today we spent the afternoon in Washington Square Park and played Scrabble.
Back in New York City tonight.
Patrick Boettcher accepted my i2c changes into his v4l branch and has submitted a pull request to Mauro. Tonight I sent the final set of changes that actually add support for the Pinnacle 801e (the i2c fix was separated out from the device support patch). If all goes well, this stuff will get into the mainline in the next few days.
Also submitted patch attempt #2 for the ATSC Extended Names support for Kaffeine. There were a few useful comments and a whole lot of what I will call "style issues". It's kind of annoying submitting to someone else's style, especially when the suggestions aren't really better and in fact contradict good practice learned in my years of doing protocol work.
For example, let's say there are ten possible values for a field. And let's assume that we implement support for two of those values, we explicitly don't add support for three values, and the other 5 are outright illegal. I believe it makes sense to break out the individual values, and for the ones that we don't support put a block indicating what each value means and that it's not supported (to make it easier for others to add it in the future). Further, if we hit illegal values, we should definitely log those. The point is I believe in making the code easy to extend and I think it's important to differentiate between things that are valid but we simply don't support and things that are outright invalid and should never appear.
His approach is to just have the three values we support, and drop everything else on the floor as "unknown".
